gtalarico / pyairtable

Python Api Client for Airtable
https://pyairtable.readthedocs.io
MIT License
786 stars 139 forks source link

Add return_fields_by_field_id to Table.update() #320

Closed marks closed 11 months ago

marks commented 11 months ago

As requested and discussed in #307 , this adds support for setting return_fields_by_field_id on Table.update() calls.

The Airtable API began supporting this on 10/3/2023.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5b30630) 99.60% compared to head (27a8100) 99.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #320 +/- ## ======================================= Coverage 99.60% 99.60% ======================================= Files 24 24 Lines 1791 1791 ======================================= Hits 1784 1784 Misses 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marks commented 11 months ago

BTW - maintainers - is there documentation for running integration tests locally? I was able to figure out what I needed to create in Airtable in tests/integration/conftest.py and related tests, but just curious if I had missed something

mesozoic commented 11 months ago

Thanks for adding this, @marks! Right now the repo requires all commits to be signed; so that you get credit for the PR, could you enable signed commits and rebase your branch?

We do not have any documentation for the integration tests; that's a todo I never got around to. They should work out-of-the-box with creator privileges on the test base, and I just sent you an invite for that. However, the non-integration test suite should still provide as close to 100% test coverage as possible.

marks commented 11 months ago

Ah, thank you @mesozoic !

All commits for this branch/PR should be signed/verified now.