Closed BAPCon closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.60%. Comparing base (
1ed6109
) to head (3afde50
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Good catch - thanks for the bug report! Per our contribution guidelines could you add something to our regression tests which (1) fails on the main
branch and (2) passes with this change?
This should do it, though I am not super confident in my test writing ability lol. Let me know if more changes are needed
Thanks for contributing! I'll get a bugfix release out today.
Turn on
force
duringbase.create_table
when trying to return the newly created table. The newly created table is not included in the cached tables, settingforce
toTrue
makes sure to use the updated table list.I believe this is necessary, as adding a
force
parameter to the arguments list ofbase.create_table
does not make sense. I can't see any utility in not refreshing the tables list, unless we set returning the new table to optional.See issue #343