gtalarico / pyairtable

Python Api Client for Airtable
https://pyairtable.readthedocs.io
MIT License
784 stars 138 forks source link

Update `base.create_table` #345

Closed BAPCon closed 7 months ago

BAPCon commented 7 months ago

Turn on force during base.create_table when trying to return the newly created table. The newly created table is not included in the cached tables, setting force to True makes sure to use the updated table list.

I believe this is necessary, as adding a force parameter to the arguments list of base.create_table does not make sense. I can't see any utility in not refreshing the tables list, unless we set returning the new table to optional.

See issue #343

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.60%. Comparing base (1ed6109) to head (3afde50). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #345 +/- ## ========================================== - Coverage 99.65% 99.60% -0.05% ========================================== Files 25 25 Lines 2023 2025 +2 ========================================== + Hits 2016 2017 +1 - Misses 7 8 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mesozoic commented 7 months ago

Good catch - thanks for the bug report! Per our contribution guidelines could you add something to our regression tests which (1) fails on the main branch and (2) passes with this change?

BAPCon commented 7 months ago

This should do it, though I am not super confident in my test writing ability lol. Let me know if more changes are needed

mesozoic commented 7 months ago

Thanks for contributing! I'll get a bugfix release out today.