search

gtalarico / pyairtable

Python Api Client for Airtable
https://pyairtable.readthedocs.io
MIT License
765 stars 138 forks source link

Bug fix for deprecated `metadata.get_table_schema` #349

Closed BAPCon closed 6 months ago

BAPCon commented 6 months ago

Fixes the bug described in #314 Adds test case in tests\test_api_table

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.60%. Comparing base (bbcd7ae) to head (1b3f592).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #349 +/- ## ======================================= Coverage 99.60% 99.60% ======================================= Files 25 25 Lines 2025 2025 ======================================= Hits 2017 2017 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mesozoic commented 6 months ago

Do we need to fix this bug? I'd planned on removing this module in the 3.0 release, and Table.schema() offers equivalent functionality without this limitation.

BAPCon commented 6 months ago

Not sure, I figured since #314 was still open and had been updated/labeled as bug that we were looking to fix it. I figure if the deprecated feature is still active that a bugfix make sense, but it's up to you!

mesozoic commented 6 months ago

Can't hurt to close the ticket, then. I'll merge it and do one more bugfix release before 3.0. Thanks for contributing!