search

gtalarico / pyairtable

Python Api Client for Airtable
https://pyairtable.readthedocs.io
MIT License
784 stars 138 forks source link

Rename `return_fields_by_field_id=` to `use_field_ids=` #362

Closed mesozoic closed 7 months ago

mesozoic commented 7 months ago

This is a breaking change for 3.0 and it's totally cosmetic and silly, but I find the name "return fields by field id" to be way too much of a mouthful. We called this use_field_ids in #355 and I'd like to rename the kwarg to match. When users upgrade the package it should be easy enough to search/replace everywhere. I am comfortable being told this is a bad idea anyway.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (919f57d) to head (fade681).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 24 24 Lines 2379 2379 ========================================= Hits 2379 2379 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gtalarico commented 7 months ago

@mesozoic +1 That always bothered me as well