ristretto255: align the API with filippo.io/edwards25519

gtank / ristretto255

Implements ristretto255, a fast prime-order group.

https://ristretto.group

BSD 3-Clause "New" or "Revised" License

98 stars 22 forks source link

ristretto255: align the API with filippo.io/edwards25519 #39

Closed FiloSottile closed 3 years ago

FiloSottile commented 3 years ago

Fixes #36

gtank commented 3 years ago

As I recall, the main question here was if we wanted to keep the alignment with the encode/decode naming scheme of the draft. Otherwise looks fine to me.

FiloSottile commented 3 years ago

Right. Coming back to this, I think the Set/Bytes names are a little better, the spec doesn't prescribe API names anymore (they are just "the encoding function" etc.), and changing the name lets us also change the signature which I think is a clear improvement. I've grown convinced we should merge this.