gtanner / qrcode-terminal

QRCodes in your terminal, cause thats hot.
Apache License 2.0
1.28k stars 102 forks source link

Provided the functionality of error code levels for QR Code generation #11

Closed spiside closed 9 years ago

spiside commented 9 years ago

A user should be able to set their own error level when generating a QR Code. Personally, I was having issues with the size of the QR Code in the terminal screen using the error level 'H'. Since the error correct level is commonly used for recovering data when the QR code is damaged, having an error level 'H' seems like overkill when displaying in the terminal.

Status: Requesting Merge

Reviewers: \ @gtanner @mwbrooks **

Changes

mwbrooks commented 9 years ago

Hi @spiside, awesome pull request! I made a small comment on the documentation, but the rest looks good to me and the tests are passing.

spiside commented 9 years ago

Hey @mwbrooks, I changed the explicit parameter naming of setErrorLevel(error='Q'). Thanks for the recommendation.

mwbrooks commented 9 years ago

@spiside cool! Although, you actually taught me something today. I like the self-documenting style of (error='Q') and after thinking about it, it makes sense why it works. I was just a dummy and without my morning coffee. Thanks for changing it though - I imagine it's more expected for most people.

mwbrooks commented 9 years ago

Tagged and published!

qrcode-terminal@0.10.0
spiside commented 9 years ago

Awesome! Thanks 😸, and after a bit of research, it seems the consensus for explicit parameter naming should happen with multiple parameters. Using it for just one seems unnecessary :)

mwbrooks commented 9 years ago

Good to know!