search

gtanner / qrcode-terminal

QRCodes in your terminal, cause thats hot.
Apache License 2.0
1.28k stars 102 forks source link

Small qrcode output #13

Closed goorockey closed 9 years ago

goorockey commented 9 years ago

Support small qrcode output by combine adjacent row and using unicode character.

Screenshot:

small_qr

Related issue: #9

mwbrooks commented 9 years ago

This is really awesome @goorockey!

I think I'd prefer the small QRCode to be the default on. What do you think @gtanner?

gtanner commented 9 years ago

I like the small one for the default as well. @mwbrooks, @goorockey.

I will merge this in and bundle up a release :)

gtanner commented 9 years ago

Small seems distorted to me. screen shot 2015-11-17 at 11 30 26 am

mwbrooks commented 9 years ago

Same :( with 13pt Source Code Pro font.

screen shot 2015-11-17 at 9 03 55 am
gtanner commented 9 years ago

Thoughts?

Sadly I merged this in blind :( I didn't publish so isn't that bad.

I could roll back or rebase out the commit, or leave it in while we figure out a good way to get the small version working.

mwbrooks commented 9 years ago

No bright ideas on my end. @goorockey?

goorockey commented 9 years ago

According to the standard of unicode, there should not be gaps.

When emulating terminal applications, fonts that implement the block element characters should be designed so that adjacent glyphs for characters such as U+2588 full block create solid patterns with no gaps between them.

So I consider it's the issue of fonts that don't implement block elements correctly.

Anyway, the distorted qrcode can still be decoded correctly. :joy:

goorockey commented 9 years ago

I think it's reasonable to notice in README that the small qrcode depends on the font that you are using.