gtanner / qrcode-terminal

QRCodes in your terminal, cause thats hot.
Apache License 2.0
1.28k stars 102 forks source link

Accept piped input #19

Closed kblum closed 6 years ago

kblum commented 8 years ago

This pull request makes it possible to generate QR Codes by piping data to the CLI tool.

Accepting input as argument (standard usage):

./bin/qrcode-terminal.js 'http://github.com'
qrcode-terminal-argument

Accepting piped input:

echo 'http://github.com' | ./bin/qrcode-terminal.js
qrcode-terminal-pipe

Fixes #18

siddhartpai commented 6 years ago

This is a great pull request, @gtanner Can you please merge this off and release a better version of qr-code terminal

mwbrooks commented 6 years ago

Hey @kblum and @siddhartpai, I think this PR looks great as well. Works locally and tests all pass.

I still have commit and npm access, so I'll cut a release for you!

mwbrooks commented 6 years ago

Published on npm as qrcode-terminal@0.12.0 https://www.npmjs.com/package/qrcode-terminal

Thanks again @kblum 💯

gtanner commented 6 years ago

Awesome!

Thanks


From: Michael Brooks notifications@github.com Sent: Tuesday, March 20, 2018 4:24:59 PM To: gtanner/qrcode-terminal Cc: Gord Tanner; Mention Subject: Re: [gtanner/qrcode-terminal] Accept piped input (#19)

Published on npm as qrcode-terminal@0.12.0 https://www.npmjs.com/package/qrcode-terminal

Thanks again @kblumhttps://github.com/kblum 💯

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/gtanner/qrcode-terminal/pull/19#issuecomment-374744117, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AATWezJKbTwbV-FDFf7iaqnz27VoYWbqks5tgWWbgaJpZM4KbSLM.