gtanner / qrcode-terminal

QRCodes in your terminal, cause thats hot.
Apache License 2.0
1.28k stars 102 forks source link

chore: fix license to be valid SPDX #45

Open mojoaxel opened 3 years ago

mojoaxel commented 3 years ago

This changes the license to a be a correct SPDX type. Currently the package.json is invalid.

The npm docs clearly state that a "licenses array" is (no longer?) valid:

// Not valid metadata
{
  "licenses" : [
    {
      "type": "MIT",
      "url": "https://www.opensource.org/licenses/mit-license.php"
    },
    {
      "type": "Apache-2.0",
      "url": "https://opensource.org/licenses/apache2.0.php"
    }
  ]
}
yeldiRium commented 3 years ago

Bumping this PR, since the invalid SPDX expression makes license compatibility checks harder than necessary.

sethidden commented 1 year ago

@gtanner Would you mind please taking a look? :) The "Apache 2.0" in the license field isn't a valid SPDX identifier because it's missing a dash https://spdx.org/licenses/Apache-2.0.html.

The missing dash makes license compliance scanning of dependencies troublesome. Most people will have Apache-2.0 on their allowed licenses list, but "Apache 2.0" with no dash is unexpected

xjunior commented 1 year ago

Good morning. Thanks for the good job on qacode-terminal. Any chance this could be fixed soon? As @yeldiRium said:

the invalid SPDX expression makes license compatibility checks harder than necessary.