search

gtap-dev / javascript

JavaScript Style Guide
MIT License
0 stars 0 forks source link

Remove the React style guide for now? #17

Open mjomble opened 3 years ago

mjomble commented 3 years ago

The React style guide is quite outdated, mostly talking about class components while we almost exclusively use function components. Even React.createClass is mentioned in a way that makes it seem almost relevant 😄

To match what we actually do in React code, the guide would basically need to be rewritten from scratch.

As that's a larger undertaking, I propose we remove it for now. Otherwise developers new to React might find it and assume the information is relevant.

I'm not sure if we use CSS-in-JavaScript somewhere, but if not, we should probably remove that guide as well.

mjomble commented 2 months ago

There are also some JSX formatting rules that are valid, but could become irrelevant with #19