gtarawneh / languagetool-sublime

Proof-reading and grammar checker for English, French, German, Polish and 20+ other languages
72 stars 13 forks source link

Variable languagetool_server_remote is never used? #26

Closed n0guest closed 7 years ago

n0guest commented 7 years ago

Hi.

I tried to change remote server URL by copying LanguageTool.sublime-settings (from package) as Packages/User/LanguageTool.sublime-settings. But it seems like "languagetool_server_remote" is never used, because LanguageTool.py logic of server selections:

        if forceServer is None:
                forceServer = settings.get('default_server', 'remote')
        if forceServer == "local":
                server = settings.get('languagetool_server_local', 'http://localhost:8081/v2/check')
        else:
                server = settings.get('languagetool_server', 'https://languagetool.org/api/v2/check')
        return server

And if you have value "remote" in "default_server" then code above will choose 'https://languagetool.org/api/v2/check' as server URL.

Am i missing something or it's really broken?

Thanks.

gtarawneh commented 7 years ago

Yeah it's incorrect; the setting in the else branch should be languagetool_server_remote, not languagetool_server. Good catch!

n0guest commented 7 years ago

Thanks for the fix. BTW, when it will be available via Package Control in Sublime? Do you upload it manually or automatically?

gtarawneh commented 7 years ago

You're welcome. I need to double check that the latest commits are stable for a release, which might take few days, but the master branch is generally stable so you can safely install from this repo directly using Package Control: Add Repository.