search

gtaylor / django-athumb

A Django thumbnailer specifically optimized for S3.
http://pypi.python.org/pypi/django-athumb/
BSD 3-Clause "New" or "Revised" License
55 stars 45 forks source link

README - Configuration #17

Closed gterzian closed 11 years ago

gterzian commented 11 years ago

In the README, I would change this:

You do not need to specify a cache buster.

into:

You will need to specify a cache buster variable in your settings.py, but it can just be an empty string.

The generate_url field method seems to require a cache buster variable in the settings file, without it I got an AttributeError : 'Settings' object has no attribute 'MEDIA_CACHE_BUSTER'

gtaylor commented 11 years ago

I just need to fix this to work as the docs state. I'd hate to have to make people specify an empty string. If you got ambitious and wanted to tackle this, it'd be pretty simple and I'd get it merged in immediately.

gtaylor commented 11 years ago

I was looking into this, and it appears that this is already optional. If you ended up with an older version of django-athumb, you may be seeing this error. Here's the commit that made MEDIA_CACHE_BUSTER optional:

https://github.com/gtaylor/django-athumb/commit/3d29f6b579565d7cbd7c89c642ab159b52d743b6#athumb/fields.py