search

gtaylor / django-athumb

A Django thumbnailer specifically optimized for S3.
http://pypi.python.org/pypi/django-athumb/
BSD 3-Clause "New" or "Revised" License
55 stars 45 forks source link

bad url mapping #7

Closed AdrienLemaire closed 12 years ago

AdrienLemaire commented 12 years ago

Your S3BotoStorage_AllPublic backend assumes that every user has a bucket_cname, or return "http://s3.amazonaws.com/%s/%s" % (self.bucket_name, name)

That is not correct, I'd need the url to be "https://s3-ap-northeast-1.amazonaws.com/%s/%s/" % (self.bucket_name, name)

django-sqs introduces a AWS_REGION settings (in my case equal to 'ap-northeast-1'), and build it correctly this way. Would be nice if django-athumb could use the same settings, thanks !

gtaylor commented 12 years ago

Good idea. If you're able to submit a pull request, that'd be the fastest way to get this in. Otherwise, I'll try to get to it sometime this week.

AdrienLemaire commented 12 years ago

Couldn't attach the patch to this issue, so I close this one. Please see #8

Note that django-athumb seriously needs tests. I don't have enough time to write a test suite for you, but hope that you'll find some time for :)

Thanks for your work !