search

gtaylor / python-colormath

A python module that abstracts common color math operations. For example, converting from CIE L*a*b to XYZ, or from RGB to CMYK
python-colormath.readthedocs.org
BSD 3-Clause "New" or "Revised" License
456 stars 82 forks source link

PR: Code formatting using Black and Flake8. #101

Closed KelSolaar closed 4 years ago

KelSolaar commented 4 years ago

The following commands were used:

$ black .
$ flake8 --max-line-length=90

black defaults to 88 line length but might go slightly over, 90 max length for Flake8 is thus a good default.

I added an extra_require attribute to the setup.py file so that doing pip install .[development] will install all the development dependencies.

I have also setup some pre-commit hooks that should be installed as follows: pre-commit install --install-hooks and will run black and flake8 before committing.

KelSolaar commented 4 years ago

@gtaylor : This is quite a radical change but it will make future contributions smoother! Would be great to get your stamp on this one.

Cheers,

Thomas

KelSolaar commented 4 years ago

I will merge that one!