gtaylor / python-colormath

A python module that abstracts common color math operations. For example, converting from CIE L*a*b to XYZ, or from RGB to CMYK
python-colormath.readthedocs.org
BSD 3-Clause "New" or "Revised" License
456 stars 82 forks source link

Add RGB_to_YIQ and YIQ_to_RGB #105

Open Mattwmaster58 opened 4 years ago

Mattwmaster58 commented 4 years ago

Inspired by scikit's implementation.

Mattwmaster58 commented 2 years ago

Any chance we could get this merged/reviewed?

KelSolaar commented 2 years ago

Hi @Mattwmaster58,

Any reason for not using Scikit-Image conversion? It is already there, vectorised and unit tested.

Mattwmaster58 commented 2 years ago

Sometimes one may prefer a "lighter" library.

KelSolaar commented 2 years ago

That makes sense but then adding new features does not contribute to keep it lightweight. What is the use case for YUV/YIQ?

Mattwmaster58 commented 2 years ago

Understandable. The line between 'lightweight' is sometimes hard to draw. I believe my use case here was a small image comparison library, but I'm not actively working with it at the moment. If you don't want to add this for lightweight/testing concerns I can understand