don't crash when using a CNAME ALIAS with zone.record_sets

gtaylor / python-route53

A simple Python 2.7/3.x compatible Route53 module. [UNMAINTAINED]

https://python-route53.readthedocs.org

MIT License

40 stars 21 forks source link

don't crash when using a CNAME ALIAS with zone.record_sets #11

Closed frankbb closed 9 years ago

frankbb commented 9 years ago

This will solve issue #8, i tested this with a CNAME ALIAS and also tried to use record_set.is_alias_record_set()

when you try to print a record_set that is a CNAME ALIAS you will get: TypeError: init() got an unexpected keyword argument 'alias_hosted_zone_id'

gtaylor commented 9 years ago

Wonderful, thanks! Maybe you could open an issue to nag me to release this to PyPi before I forget :)