gtd / csv_builder

CSV template handler for Rails 3
MIT License
82 stars 35 forks source link

Fix iconv deprecation warnings in 1 9 #10

Closed mocoso closed 12 years ago

mocoso commented 12 years ago

By relying on 1.9's built in encoding support (String#encode) rather than iconv

Also fixes spec failure with v1.9.3

gtd commented 12 years ago

Thanks mate!

jpslav commented 12 years ago

Howdy @dasil003 - any chance you could release a new gem version that has this deprecation warning fix. Would be much appreciated!

gtd commented 12 years ago

2.1.1 is up. Not sure why I didn't do it before. Date is wrong since I'm still learning this non-jeweler workflow ;)

jpslav commented 12 years ago

Awesome -- thanks!