search

gtd / csv_builder

CSV template handler for Rails 3
MIT License
82 stars 35 forks source link

Activate travis-ci? #17

Closed donv closed 3 years ago

donv commented 3 years ago

Hi!

I see there are some specs and there is a travis-ci config, but it looks like travis is not activated.

Maybe activate it? I can help setting it up and maintain it if needed.

donv commented 3 years ago

I think the way forward would be GitHub Actions. I can submit a PR for this if you like.

gtd commented 3 years ago

Yes I was thinking the same, PR is definitely welcome.

donv commented 3 years ago

@gtd Are you able to run the tests in your environment? If so, what version of Ruby and Rails are you using?

gtd commented 3 years ago

I have not run specs on my current machine and I see there are a lot of compatibility issues with newer versions of various gems. I'm attempting to put some pessimistic constraints in to see if I can get them running again.

donv commented 3 years ago

I think the gem is OK in itself, and that the problems are mostly around the specs and gem setup. I have been using the gem without problems for many years on the newest Ruby/Rails combos.

gtd commented 3 years ago

Okay I got specs running on ruby 2.5.7 and rails 4.2.11.3. Changes pushed to master. Could you let me know if it works for you on a clean bundle install?

gtd commented 3 years ago

Alright, I have it working through all currently supported rails versions. Github Actions is set up to run the specs on rails 6.1.x for ruby 2.5, 2.6, and 2.7.

Next steps would be: