search

gtdiehl / iotawatt_ha

IoTaWatt for Home Assistant
Apache License 2.0
16 stars 16 forks source link

Submit to Home Assistant Core #4

Closed balloob closed 3 years ago

balloob commented 3 years ago

Home Assistant will have a new added focus on energy management in the next release. We're trying to get as many energy related integrations part of core.

Your integration is great. Would you want to submit it to core?

Edit: to avoid unnecessary noise, please don't comment with "+1" or similar. Just use the thumbs up reaction on the first post.

jherby2k commented 3 years ago

This would be awesome!

gtdiehl commented 3 years ago

Yeah I can help clean up the sensor code a bit a submit it

balloob commented 3 years ago

That's great. Tag me when you put up the PR and I'll prioritize review 👍

skippy-oz commented 3 years ago

That would be great

pvizeli commented 3 years ago

Yeah, I think the code is not bad. Open a PR and with some reviews it should be done soon

gtdiehl commented 3 years ago

I want to open a PR for Home Assistant though I am concerned about Issue #1

balloob commented 3 years ago

Don't worry about #1, it can be fixed later too.

gtdiehl commented 3 years ago

I created a PR for the IoTaWatt integration to be added to Home Assistant Core. https://github.com/home-assistant/core/pull/55364