search

gtfierro / brick-occupancy-extension

5 stars 1 forks source link

thermal sensation unit #2

Open ZhelunChen opened 10 months ago

ZhelunChen commented 10 months ago

https://github.com/gtfierro/brick-occupancy-extension/blob/143ecc0df8ee528b7fbe53547d268db05793ee1a/points.ttl#L66

I am wondering why thermal sensation has a Clo unit. Could it be a typo?

gtfierro commented 10 months ago

clo is a unit of clothing insulation: https://en.wikipedia.org/wiki/Clothing_insulation#Clothing_ensembles_and_garments

ZhelunChen commented 10 months ago

My bad, wasn't being clear. Should have referenced the whole thing. What I meant was OccupantThermalSensation shouldn't have a Clo unit. I am new to ontology, but I think the definition here forces it to have Clo unit.

https://github.com/gtfierro/brick-occupancy-extension/blob/143ecc0df8ee528b7fbe53547d268db05793ee1a/points.ttl#L61-L68

ruijis commented 10 months ago

Thermal sensation should not have a unit. It has a scale. The most common thermal sensation scale is ASHRAE 7-point scale, from -3 to +3

On Fri, Nov 17, 2023 at 7:40 AM Zhelun Chen @.***> wrote:

My bad, wasn't being clear. Should have referenced the whole thing. What I meant was OccupantThermalSensation shouldn't have a Clo unit. I am new to ontology, but I think the definition here forces it to have Clo unit.

https://github.com/gtfierro/brick-occupancy-extension/blob/143ecc0df8ee528b7fbe53547d268db05793ee1a/points.ttl#L61-L68

— Reply to this email directly, view it on GitHub https://github.com/gtfierro/brick-occupancy-extension/issues/2#issuecomment-1816654381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKX6BL4VSAFZFRQAS37GIT3YE6APBAVCNFSM6AAAAAA7PILA4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGY2TIMZYGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

gtfierro commented 9 months ago

We would welcome a PR to fix this!