search

gtfierro / reasonable

OWL 2 Reasoner built on DataFrog
BSD 3-Clause "New" or "Revised" License
67 stars 4 forks source link

Python packages: Add cmdline flags for macos, change crate names to fix build #7

Closed epaulson closed 3 years ago

epaulson commented 3 years ago

I am just fumbling around with Rust so that this seems to work is as much dumb luck as anything that means I know what I'm doing, but I was able to run the test program from the README with these changes on MacOS. There may be a better way.

The crate changes to src/python.rs I think I required no matter what - without them, running cargo build --lib --release --features "python-library" fails on Linux (Ubuntu 18.04 VM) and MacOS

The addition to .cargo/config comes straight from the manual at https://pyo3.rs/v0.12.1/

I did not try anything with maturin so for all I know this blows all the pypi & wheel stuff up completely.

I'm on the nightly toolchain

(reason) epaulson:~/development/reasonable $ rustc --version
rustc 1.49.0-nightly (b1af43bc6 2020-10-10)
(reason) epaulson:~/development/reasonable $ rustup toolchain list
stable-x86_64-apple-darwin (default)
nightly-x86_64-apple-darwin (override)

Reasonable (but not the python library) does build without these changes - if I just do a 'make build' I get an executable at the end in the target/release directory.

gtfierro commented 3 years ago

@epaulson I think I got Actions working for builds; when you get a chance, can you try doing pip install reasonable==0.1.24 and see if that works for you on your Mac?