search

gtfierro / simulated-digital-twin

BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

updated boptest bacnet proxy #2

Open epaulson opened 1 year ago

epaulson commented 1 year ago

I updated the bacnet proxy to use the 0.3.0 boptest API. You should be able to drop most of your changes in the patch to BopTestProxy. You can now give the boptest URL as a commandline option.

The bacpypes.ini file will still need to be to be patched, bacpypes can't take its IP address through a commandline argument or env variable, it's got to be in the .ini file. (Same with the object identifier).

BACpypes can take a commandline argument of where to find the .ini file, though - so maybe it'd be better if the docker-compose setup could at least the object identifier as a commandline/env variable and then maybe a script could write out a .ini file in the container and pass that as a commandline argument to BopTestProxy.

gtfierro commented 1 year ago

Thanks! I have updated the repo -- the one fix is the global declaration at https://github.com/epaulson/boptest-bacnet-proxy/blob/main/BopTestProxy.py#L235 needs to be updated so that baseurl is also considered a global variable