search

gtfierro / xboswave

eXtensible Building Operating System built on WAVE and WAVEMQ
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

ingester.yml should be ingester.template #6

Closed akshephard closed 5 years ago

akshephard commented 5 years ago

To prevent overwriting config files which are actually filled out when merging changes from upstream the template config file should not be named the same as the one actually used.

gtfierro commented 5 years ago

I'm of a different mind here. I think its a better solution to copy the ingester.yml file to a dedicated location that isn't the same as the "development" version (e.g. /etc/ingester/ingester.yml), and then point the ingester process to that file. In a real deployment, you likely aren't going to be running the ingester by building the binary from source and executing from the repo directory.

This requires having the ingester take the configuration file as an argument, which is a simple fix

gtfierro commented 5 years ago

https://github.com/gtfierro/xboswave/commit/671ada7f9ac7e6e9b2ce7e75b0ff1fd43201aa13

akshephard commented 5 years ago

Ah okay. I'm assuming you are of the same mindset for the driver config files as well?

gtfierro commented 5 years ago

Definitely! Nothing should execute out of the git repo

gtfierro commented 5 years ago

Definitely! Nothing should execute out of the git repo