gtg922r / obsidian-numerals

An obsidian plugin which turns a math code block into a full featured calculator
Other
391 stars 8 forks source link

Decimal separator #19

Closed yakovlev-i-a closed 1 year ago

yakovlev-i-a commented 1 year ago

Thank you for useful plugin! In my computer with Windows 10 I set Decimal Symbol to dot in Regional and Language Options. However, in the rendered view I still see commas. It would be nice to define the decimal symbol in Plugin Settings explicitly as a suggestion.

image

gtg922r commented 1 year ago

@yakovlev-i-a just to confirm you are talking about in the rendered results, correct?

I use a javascript function toLocaleString()that should account for your language and locale and deduce the correct format.

Would you mind sharing your current locale by opening up the console in obsidian (alt-ctrl/cmd-i), and typing navigator.language in the console?. You should see something like en-US or ru-RU, etc

If possible I'd like for this to be auto-detected and not have to add another setting. Though if its necessary I will.

yakovlev-i-a commented 1 year ago

Thank you for your comment. I see the value ru in the console. Within this locale, a comma is used as a decimal separator indeed. But I would prefer to change it to a dot. As I reported, changing the parameter in Regional and Language Options in Windows settings does not help, as well as language changing to English in the Obsidian setting. Probably, I should change my locale somewhere else, but I don't know. For example, Excel has the option to use a system separator or directly defined symbols (as in the screenshot below). A similar option in the plugin settings would be helpful to someone who wants to see the separator symbol different from the locale settings. image

gtg922r commented 1 year ago

Adding the ability to specify the locale directly, which should fix your issue.

gtg922r commented 1 year ago

The new 1.2 release gives you the option to choose your number formatting option. Update to the latest version of Numerals, open Numerals settings, and scroll down to Rendered Number Format. The default is your system setting, but you can the format you'd like to force Numerals to use.

Please check it out and re-open this if you are still having issues!