search

gtgalone / currency_text_input_formatter

Currency Text Input Formatter for Flutter.
https://pub.dev/packages/currency_text_input_formatter
MIT License
50 stars 29 forks source link

removed turnoffGrouping only for the constructor that accepts format #54

Closed rsegecin closed 6 months ago

rsegecin commented 6 months ago

I'm sorry to bother again in a such a short notice but I caught something that could lead to an error.

"The constructor of CurrencyTextInputFormatter does not necessarily require the turnOffGrouping parameter, as this functionality can be managed through the format parameter instance itself. Including turnOffGrouping in the main constructor may introduce potential errors."

CurrencyTextInputFormatter.currency and CurrencyTextInputFormatter.simpleCurrency they are still keeping turnOffGrouping for the library functionality.

I've also changed the CurrencyTextInputFormatter to also accept olders intl dependencies from intl: '>=0.17.0-0 <=0.19.0'. Having intl since 0.17.0 won't affect CurrencyTextInputFormatter its the same range used by easy_localization package.

gtgalone commented 6 months ago

@rsegecin Thanks! I just released with your fix.

rsegecin commented 6 months ago

thank you again.