search

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.
https://pub.dev/packages/libadwaita
Mozilla Public License 2.0
238 stars 17 forks source link

Introduce `AdwButton` widget #38

Closed jesusrp98 closed 2 years ago

jesusrp98 commented 2 years ago

This PR introduces a new widget RawAdwTarget. This widget could be useful when you want to build a button or any clickable widget: AdwSidebarItem, AdwTextButton etc.

Included in this PR is a rework on the AdwHeaderButton using this new widget, in order to illustrate how this new widget could be used.

Let me know what you think about this widget and its use in the app.

jesusrp98 commented 2 years ago

My plan is to build all the available buttons inside GTK's libadwaita.

image

prateekmedia commented 2 years ago

Looks good!

jesusrp98 commented 2 years ago

Just added a couple more parameters to the RawAdwTarget: boxShadows, shape and border.

They could be useful in the future when using this class :)

MalcolmMielle commented 2 years ago

Excellent commits. I have a couple of small remarks but overall it's a great contribution thanks :).

MalcolmMielle commented 2 years ago

@prateekmedia could we merge #42 before merging this one so that the check will pass (unless you're almost done?). And then we'll do another PR to add the macos action. Does that sound good to you :)?

jesusrp98 commented 2 years ago

@prateekmedia could we merge #42 before merging this one so that the check will pass (unless you're almost done?). And then we'll do another PR to add the macos action. Does that sound good to you :)?

Sounds great! Please merge this PR once all pending ones are done :)

MalcolmMielle commented 2 years ago

@jesusrp98 I'm not sure what is going on with the linter at the moment :S. Could you try rebasing your branch on main to see if that helps?

MalcolmMielle commented 2 years ago

Nevermind I think the error is due to this issue ? it's surprising it passed before

jesusrp98 commented 2 years ago

Nevermind I think the error is due to this issue ? it's surprising it passed before

I'll wait haha.

MalcolmMielle commented 2 years ago

Should be solved by #44

MalcolmMielle commented 2 years ago

Bear with me @jesusrp98 can you rebase your commit, so the new linter is triggered :| ? If it does not work, I'll be so sad.

MalcolmMielle commented 2 years ago

Yes finally :D! Thanks a lot for everything @jesusrp98