Fix CI analyze - Githubissues

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.

https://pub.dev/packages/libadwaita

Mozilla Public License 2.0

249 stars 19 forks source link

Fix CI analyze #42

Closed MalcolmMielle closed 2 years ago

MalcolmMielle commented 2 years ago

Trying to fix the linting CI... :(

prateekmedia commented 2 years ago

I think a better CI would be Just:

flutter pub get
flutter analyze . example

MalcolmMielle commented 2 years ago

I think a better CI would be Just:
flutter pub get
flutter analyze . example

Sure :).

@prateekmedia, it seems that the example app is not building on macos because of bitsdojo_windows. Any idea why? I have zero knowledge of macos :S.

prateekmedia commented 2 years ago

@prateekmedia, it seems that the example app is not building on macos because of bitsdojo_windows. Any idea why? I have zero knowledge of macos :S.

https://pub.dev/packages/bitsdojo_window has some instructions to follow for macos build.

MalcolmMielle commented 2 years ago

I ended up removing the macos build example. It can be trivially added back (and I think in the long run it should be since we claim to work on all platform) but I don't have the hardware and time to fix that and it seems low priority :|. Tell me if you agree.

prateekmedia commented 2 years ago

It can be fixed by following these steps

Running flutter config enable macos desktop
Now running flutter create . --platform=macos
Now modifying the files as suggested by bitsdojo readme
Now remove all other files from macos folder other than that we modified
Now push the changes to the branch

Although I will do it if you dont want that.

MalcolmMielle commented 2 years ago

I would be great if you could add it. Thank you :D