search

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.
https://pub.dev/packages/libadwaita
Mozilla Public License 2.0
249 stars 19 forks source link

Removing dart from the super-linter. #44

Closed MalcolmMielle closed 2 years ago

prateekmedia commented 2 years ago

I think flutter pub get would not work as flutter is not installed in lint ci, Why not just add super linter to the ci.yml and not build the app at all, I think flutter analyze is enough and building is not necessary. I am open for opinions.

MalcolmMielle commented 2 years ago

That's almost exactly what I just did! Agreed 100%.

I removed dart from the super-linter so it will lint everything else. CI.yml already does the analyze. And I found why the previous run passed: the lint.yml file had the ENV variable VALIDATE_ALL_CODEBASE set to false which only scans files updated in the PR.

Is that solution good for you :)?

jesusrp98 commented 2 years ago

It works now!!

prateekmedia commented 2 years ago

If it will not validate the main dart code then what's the point of the linter?

MalcolmMielle commented 2 years ago

Validating the markdown files, CI yml files, and checking that no GitHub secret is leaked. Up to you if you think it's useful :). I'm open about it :).