View Switcher Improvements - Githubissues

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.

https://pub.dev/packages/libadwaita

Mozilla Public License 2.0

238 stars 17 forks source link

View Switcher Improvements #47

Closed prateekmedia closed 2 years ago

prateekmedia commented 2 years ago

Use AdwButton.flat as base for View switcher tab
Looks almost similar to the libadwaita one

View Switcher:

View Switcher Collapsed: View Switcher collapased

Any feedback or code suggestion is welcome.

jesusrp98 commented 2 years ago

I'm going to take a look at this PR now :)

jesusrp98 commented 2 years ago

I can't install the latest libadwaita version that includes the updated view switcher. I'm on Fedora 35 and can't compile GTK 4.5 :(

Did you manage to test the new view switcher?

prateekmedia commented 2 years ago

@jesusrp98 Yes, You can try latest libadwaita demo flatpak if it's not compiling for you.

jesusrp98 commented 2 years ago

@jesusrp98 Yes, You can try latest libadwaita demo flatpak if it's not compiling for you.

Would you be able to provide me with a link? Thanks!

EDIT: Found, thanks for the tip!

jesusrp98 commented 2 years ago

I'm going to push a couple commits into this branch. We can change anything related to them no problem :)

prateekmedia commented 2 years ago

@jesusrp98 I only have one issue left for now and that is the code duplication part.

If someone wants to have ViewSwitcher for now then they have to create two different view switcher's: One for header bar one and the other for the Bottom Navigation Bar in AdwScaffold just like #46.

This type of code duplication is not there in the Original libadwaita so we need some way to unify both Flap and View Switcher so that the developer using this doesn't have to face the same.

jesusrp98 commented 2 years ago

This issue is related, as you said, to the one related with AdwSidebar. Fixing that issue is out of scope of this PR, but we should definetly create an issue to detail how that could be fixed.

What do you think about it?

prateekmedia commented 2 years ago

@jesusrp98 Yes, That sounds good to me!