search

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.
https://pub.dev/packages/libadwaita
Mozilla Public License 2.0
238 stars 17 forks source link

Decrease JSCPD threshold, remove dry-run in publish #51

Closed MalcolmMielle closed 2 years ago

MalcolmMielle commented 2 years ago

The copy paste checker was triggered for dart constructors in class such as AdwButton which is counter-productive. I've also removed the dry-run from the publish CI.

I'm sorry. I know I've introduce the super-linter, I thought it would be good but it's more a headache in the end since most of the linter is used in ci.yaml. I still think it's useful for the Github secret check, especially once we'll publish release using the publish CI, but if you thik it's too annoying, I really don't mind removing it.

pablojimpas commented 2 years ago

Apparently jscpd can have a config file with a custom threshold, right now it's 0% but maybe setting it to a reasonable 20% (that will solve the issue found in #50) instead of disabling it altogether would be better. super-linter then checks the JSCPD_CONFIG_FILE env variable.

super-linter is definitely pedantic but it's a great tool for the long run. In any case, I think having a stricter set of analysis rules will be more useful for code quality than using super-linter. Both lint and very_good_analysis packages provide a solid foundation and are really good alternatives to the default flutter_lints, we can always tweak individual rules later as we see fit.

prateekmedia commented 2 years ago

@pablojimpas Thanks for you suggestion, I too think that flutter packages can be modified to make a strict set of analysis rules but super_linter is used for other files too like .yaml and also for Secrets leak check.

I have decreased the threshold of jscpd for now, let's hope it works.