version 1.0.0 - Githubissues

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.

https://pub.dev/packages/libadwaita

Mozilla Public License 2.0

238 stars 17 forks source link

version 1.0.0 #53

Closed prateekmedia closed 2 years ago

prateekmedia commented 2 years ago

BREAKING

AdwHeaderBar.minimal is now AdwHeaderBar.custom
Remove label parameter from AdwTextField

Changes to widgets

HeaderBar

Now the AdwHeaderBar is not dependent on any package, windowDecor object is now optional
Add isTransparent parameter => Makes AdwHeaderBar's background and border color

Popover

Revisit popup menu by using popover_gtk package (popover package with fade transition) (#35)

ViewSwitcher

Add badge in AdwViewSwitcher

New Widgets

AdwSwitch => port of GtkSwitch from gtk4
AdwAboutWindow => port of upcoming AdwAboutWindow from libadwaita

MalcolmMielle commented 2 years ago

I'll have a look as soon as I can :)

prateekmedia commented 2 years ago

I think it is ready to merge, I will ask for a final review if any and then it will be merged this week or so.

pablojimpas commented 2 years ago

I think it is ready to merge, I will ask for a final review if any and then it will be merged this week or so.

I suggest we should hold the 1.0.0 release until we find a right solution to issue #46

I haven't looked for ways to fix it but I think it's worth fixing this before a "stable" release, because a) it's bad API design and b) users of this package may expect some stability and not a lot of breaking changes in AdwSidebar which is probably one of the most essential & common widgets. There's no need to rush a release.

MalcolmMielle commented 2 years ago

While I agree with @pablojimpas that fixing #46 should come before stable release if possible, I think this PR should be merged when done and the fix to #46 should be in a different PR. It'll make it easier to review.

prateekmedia commented 2 years ago

I am soon going to create another PR to fix #46 before stable release.

prateekmedia commented 2 years ago

PR for fixing #46 is #56

pablojimpas commented 2 years ago

PR for fixing #46 is #56

Good to hear that! Maybe you can use some insight from @jesusrp98 since I think he did some research on this topic

prateekmedia commented 2 years ago

@pablojimpas Hmm, he didn't posted anything after that so maybe he got busy, Idk.