search

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.
https://pub.dev/packages/libadwaita
Mozilla Public License 2.0
238 stars 17 forks source link

Move color logic outside of libadwaita utils/colors into theme package #55

Closed MalcolmMielle closed 2 years ago

MalcolmMielle commented 2 years ago

For now, the colors used for avatars are hardcoded in utils/colors.dart. The color logic should be delegated to the theme (e.g. yaru or adwaita) and moved out of libawaita.

prateekmedia commented 2 years ago

Will yaru theme accept it?

MalcolmMielle commented 2 years ago

Maybe there is a way to do it. I'm not sure how.

prateekmedia commented 2 years ago

I think they should be hardcoded as it is the same for the original libadwaita library: https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/stylesheet/widgets/_avatar.scss

prateekmedia commented 2 years ago

If you disagree, then I will reopen the issue. I am open for suggestions.

MalcolmMielle commented 2 years ago

Ok sounds good for now :)