search

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.
https://pub.dev/packages/libadwaita
Mozilla Public License 2.0
238 stars 17 forks source link

Implement the new AdwAboutDialog #68

Open prateekmedia opened 1 year ago

prateekmedia commented 1 year ago

Design: about-dialog-detailed

After Implementation:

simrat39 commented 1 year ago

I can take this on, but from my testing on the adwaita test app, this is just a new window, not a dialog which cant leave the app, so I'm not sure if we should implement it as a dialog or not

prateekmedia commented 1 year ago

Yes but implementing it as a Window would not be a easy task may need to use multi window packages from pub.dev

simrat39 commented 1 year ago

Yeah ill just stick to a normal dialog, don't think anyone wants to move it out of the main window anyways

simrat39 commented 1 year ago

Looks like we already have something similar https://github.com/gtk-flutter/libadwaita/blob/main/lib/src/widgets/adw/about_window.dart, or is there any difference?

prateekmedia commented 1 year ago

We already have but it's not that feature rich, as It was create before the about window was merged.

Like we don't have credits, legal or acknowledgement section as shown in above Gnome Builder pics.

Although we don't need all sub categories but we need some kind of way for developers to add it

Also current about dialog doesn't have animation when navigating inside the dialog

simrat39 commented 1 year ago

Ok sounds good, so I just extend that widget then right

prateekmedia commented 1 year ago

Yes that would work

simrat39 commented 1 year ago

adw_aboot_demo

Got this much done, will continue working on it tomorrow

prateekmedia commented 1 year ago

Wow, looks great. Animation look cool.