search

gtk-flutter / libadwaita

Libadwaita's widgets for Flutter. Following Gnome HIG and available on all platforms.
https://pub.dev/packages/libadwaita
Mozilla Public License 2.0
249 stars 19 forks source link

Update components to use provider instead of theme enum #7

Closed MalcolmMielle closed 2 years ago

MalcolmMielle commented 3 years ago

Buttons, and pop ups need to be updated to use provider so that the layers of enums in gtk_colors can be removed and each element is consistent with the theming :)

prateekmedia commented 3 years ago

I don't know much but why not are we dependent on provider, let's say if someone want to use riverpod instead then they would got extra dependency of provider?

I am saying this cause I prefer riverpod.

MalcolmMielle commented 3 years ago

I've used both and I think they are both nice. If you want to switch it to riverpod that's fine by me but the PR I sent was using provider :). Now the library is stuck in a surprising in between state and I just believe it needs to be unified :).

That said the provider dep is entirely contained in the library so far.

One way to remove the provider/riverpod dependency would be to use only element of ThemeData to color the gnomeElements but for now we are using specific color attributes like headerBarBackgroundTop. That's why I used a provider GnomeTheme with those attributes. What do you see as a good solution ?

prateekmedia commented 2 years ago

All hail to libadwaita, coming from v1 and newer.