search

gtk-rs / docs

The old source repo of http://gtk-rs.org/docs/
http://gtk-rs.org/
2 stars 3 forks source link

[release] merging crate-release-update into gh-pages #24

Closed GuillaumeGomez closed 5 years ago

GuillaumeGomez commented 5 years ago

cc @GuillaumeGomez @EPashkin @sdroege

EPashkin commented 5 years ago

@GuillaumeGomez You don't know how generated "atk/auto/action.rs.html"? It not present in my local cargo doc --features "dox,embed-lgpl-docs" but current site also have both of it: https://gtk-rs.org/docs/src/atk/auto/action.rs.html https://gtk-rs.org/docs/atk/auto/action.rs.html

GuillaumeGomez commented 5 years ago

Absolutely no idea. I just run my release script on the crate branch which runs the same command you wrote...

EPashkin commented 5 years ago

Can you try run it locally on Linux? I have only one "action.rs.html" but docs have 4 (second part from gio and don't builds locally when atk documenting).

EPashkin commented 5 years ago

also no link to non "src" version in current docs master.

GuillaumeGomez commented 5 years ago

Have you tested on the crate branch? (I insist on this one.) On the crate branch, there is only the src/auto/action.rs.

EPashkin commented 5 years ago

Both files same, maybe https://github.com/gtk-rs/release/blob/master/src/release.py#L366 produced duplicates?

GuillaumeGomez commented 5 years ago

Before executing this line, we run https://github.com/gtk-rs/release/blob/master/src/release.py#L337 which removes all files in case such thing would happen. ;)

EPashkin commented 5 years ago

Have you tested on the crate branch? (I insist on this one.) On the crate branch, there is only the src/auto/action.rs.

Tested what? I don't run release script. Also in atk only one src/auto/action.rs in master branch too.

GuillaumeGomez commented 5 years ago

I'll merge this PR meanwhile, it's still an improvement to the current situation.