Closed alatiera closed 4 years ago
cc @sdroege I think this is correct but not entirely sure. The name constant there corresponds to what we would set with ClassName in C right?
The name constant there corresponds to what we would set with ClassName in C right?
Yes. That's why I usually do things different than you did here. An imp
module with struct Foo
for the implementation, and outside the imp
module a struct Foo
for the public type. This way you don't have the confusion about type names and can distinguish between the two via imp::Foo
and super::Foo
.
done as well, I think its from when I initially had implemented the functions on the public struct.
Looks good to me, @GuillaumeGomez please merge when green :)
:+1:
@GuillaumeGomez green
Thanks @alatiera !
Close #307