gtk-rs / examples

DEPRECATED, use https://github.com/gtk-rs/gtk-rs repository instead!
MIT License
283 stars 76 forks source link

Update for removal of ObjectImpl::get_type_data() #319

Closed sdroege closed 3 years ago

sdroege commented 3 years ago

CC @EPashkin @GuillaumeGomez

EPashkin commented 3 years ago

@GuillaumeGomez Please restart CI here

GuillaumeGomez commented 3 years ago

Done!

EPashkin commented 3 years ago

Strange that CI failing, @sdroege something is not merged?

EPashkin commented 3 years ago

Also here one old warning in changed files:

warning: unused import: `glib::subclass::prelude::*`
  --> src\bin\basic_subclass.rs:21:5
   |
21 | use glib::subclass::prelude::*;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: 1 warning emitted
sdroege commented 3 years ago

Hmm, did I forgot something? Let's see.

sdroege commented 3 years ago

Fixed the warning but the CI failure is simply because it uses an old version of glib for some reason. It builds fine here.

EPashkin commented 3 years ago

@sdroege Please change target branch to pending

sdroege commented 3 years ago

Ah that was the problem. Thanks :)

EPashkin commented 3 years ago

Seems CI need restarted again, Travis still think that it against master, but it now passing. Only appveyour was failed

GuillaumeGomez commented 3 years ago

Let's see now. :)

sdroege commented 3 years ago

Looks good now, thanks :)

EPashkin commented 3 years ago

CI passed

GuillaumeGomez commented 3 years ago

Thanks!