Replace builders with generated traits on ObjectBuilder

gtk-rs / gir

Tool to generate rust bindings and user API for glib-based libraries

https://gtk-rs.org/gir/book/

MIT License

236 stars 107 forks source link

Open jf2048 opened 1 year ago

jf2048 commented 1 year ago

Alternate solution to #1391. Tested with gtk4 it removes around 40,000 lines of code.

I had to remove builder_postprocess too. For that I would like to somehow come up with a way to fold the setup into FromGlibPtr and FromValue.

jf2048 commented 1 year ago

I think something needs to be done in gtk-rs-core about the missing builder_postprocess first

jf2048 commented 1 year ago

Sorry meant gtk3-rs and gtk4-rs, those seem to be the only places using it

sdroege commented 1 year ago

@jf2048 @bilelmoussaoui What's the plan/status here?

jf2048 commented 1 year ago

It is a real pain to modify that wrapper macro to do what we need to do here

jf2048 commented 1 year ago