gtk-rs / gir

Tool to generate rust bindings and user API for glib-based libraries
https://gtk-rs.org/gir/book/
MIT License
230 stars 102 forks source link

generate cfg conditions for aliases, enums, interfaces and disguised #1453

Closed fbrouille closed 1 year ago

bilelmoussaoui commented 1 year ago

Would you mind submitting a PR to at least gtk-rs-core/gtk4-rs with the changes to see how it looks like?

sdroege commented 1 year ago

Looks good to me but having a pre-view of the changes would be useful indeed.

bilelmoussaoui commented 1 year ago

The CI should be fixed once https://github.com/gtk-rs/gtk3-rs/pull/817 is merged

bilelmoussaoui commented 1 year ago

Please rebase & squash the commits into one.

fbrouille commented 1 year ago

This change does not impact generated code for gtk3-rs/gtk4-rs. I use it with other gir files (Nautilus-3.0.gir, Nautilus-4.0) to condition compilation of generated code according to some features

sdroege commented 1 year ago

Ok, let's merge it then. Thanks!