gtk-rs / gir

Tool to generate rust bindings and user API for glib-based libraries
https://gtk-rs.org/gir/book/
MIT License
230 stars 102 forks source link

docs/gi-docgen: quote arg identifiers with backticks #1464

Closed jf2048 closed 1 year ago

jf2048 commented 1 year ago

Looks like this was missed on the transition from gtk-doc. This is for things like @self and @name in https://gtk-rs.org/gtk4-rs/git/docs/gtk4/prelude/trait.WidgetExt.html#method.activate_action

And also avoid a copy when converting from Cow<str>

bilelmoussaoui commented 1 year ago

Please don't merge this. There was a reason why I didn't made this a default behaviour of gi-docgen docs and it would need more thinking

jf2048 commented 1 year ago

After matrix discussion, let's prefer to replace these upstream

jf2048 commented 1 year ago

Upstream PR here https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5897