search

gtk-rs / gir

Tool to generate rust bindings and user API for glib-based libraries
https://gtk-rs.org/gir/book/
MIT License
232 stars 105 forks source link

Support finish-func annotation #1570

Closed A6GibKm closed 4 months ago

A6GibKm commented 4 months ago

To get the correct name of the finish function if any.

A6GibKm commented 4 months ago

Found this in the process https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4099.

bilelmoussaoui commented 4 months ago

Looks good to me but we probably have to wait until that ---^--- bug is fixed and we imported that gir?

Right, at worst we could land this after #1571 and not regen gtk-rs-core until the new gir file lands. So we can test it in gtk4-rs/gstreamer-sr

bilelmoussaoui commented 4 months ago

The commit mentions it fixes https://github.com/gtk-rs/gir/issues/1561 but it doesn't cover all the other annotations. Even if we don't have an actual use of them now, it would be nice to parse the data so we can find potential breakages in the GIR files

A6GibKm commented 4 months ago

The commit mentions it fixes #1561 but it doesn't cover all the other annotations. Even if we don't have an actual use of them now, it would be nice to parse the data so we can find potential breakages in the GIR files

Added a commit I had stashed to parse them, but atm we do nothing with them.

bilelmoussaoui commented 4 months ago

Needs a rebase

A6GibKm commented 4 months ago

Needs a rebase

rebased