gtk-rs / gir

Tool to generate rust bindings and user API for glib-based libraries
https://gtk-rs.org/gir/book/
MIT License
236 stars 107 forks source link

Child properties #287

Closed EPashkin closed 8 years ago

EPashkin commented 8 years ago

There is any reason for not generate for child properties get/set-ers? Ex. for Grid function like set_child_height<T: IsA<Widget>>(&self, child:&T, value: i32) and implementing it with gtk_container_child_set_property

EPashkin commented 8 years ago

Seems no info about child properties in Gtk-3.0.gir file 😭

gkoz commented 8 years ago

We don't handle any properties yet, implementing usual properties feels like a logical first step and they are defined in girs.

EPashkin commented 8 years ago

IMHO its different issues and this better handled first by these reasons: Child properties can't be generated by girs and need be done manually, so it will be good test for properties itself; For normal properties we need solve https://github.com/gtk-rs/gir/issues/139 first as many classes already has get/set as functions with same names (and doing same work); If for properties used different method (not adding get_<prop_name>), then we need invent it first.

gkoz commented 8 years ago

Yeah, that should work too.

EPashkin commented 8 years ago

Closing this issue in favor of GTKs.