search

gtk-rs / gtk-rs-core

Rust bindings for GNOME libraries
https://gtk-rs.org/gtk-rs-core
MIT License
272 stars 104 forks source link

glib-sys: fix struct size mismatches #1360

Closed liushuyu closed 2 months ago

liushuyu commented 2 months ago

This pull request fixes the GStaticMutex and GStaticRecMutex size mismatches by removing them from the bindings.

See #1353 for more information.

sdroege commented 2 months ago

Thanks, but see the discussion (or monologue) in https://github.com/gtk-rs/gtk-rs-core/issues/1353 . I think it would be better to just not generate these types instead, like we did until (and including) the 0.18 release. These APIs are deprecated since a very long time.

liushuyu commented 2 months ago

Thanks, but see the discussion (or monologue) in #1353 . I think it would be better to just not generate these types instead, like we did until (and including) the 0.18 release. These APIs are deprecated since a very long time.

Okay, I can change this pull request to remove these struct instead

liushuyu commented 2 months ago

Done. This pull request now fixes the issue by removing those deprecated lock types.

sdroege commented 2 months ago

Thanks!

sdroege commented 2 months ago

Should probably also consider doing

- - { name: "glib", features: "v2_80", nightly: "--all-features", test_sys: false }
+ - { name: "glib", features: "v2_80", nightly: "--all-features", test_sys: true }