search

gtk-rs / gtk-rs-core

Rust bindings for GNOME libraries
https://gtk-rs.org/gtk-rs-core
MIT License
272 stars 103 forks source link

gio: make DBusConnection::register_object take optional clousures #1417

Closed pbor closed 1 month ago

pbor commented 1 month ago

The documentation states that these can be NULL so that you can decide to pass only some of them.

pbor commented 1 month ago

Looks good to me but clippy is angry

heh, I changed to not use map because I thought it was more readable... oh well, switched back to map

sdroege commented 1 month ago

Feel free to add an override for that. I agree that not using map was slightly more readable

pbor commented 1 month ago

Nah, let's merge it like this (unless you see other problems)