search

gtk-rs / gtk

DEPRECATED, use https://github.com/gtk-rs/gtk3-rs repository instead!
https://gtk-rs.org/
MIT License
1.24k stars 82 forks source link

ignore all the deprecated objects #1023

Closed bilelmoussaoui closed 8 months ago

bilelmoussaoui commented 4 years ago

I have been running gir -c ./Gir.toml -d gir-files/ -m not_bound | grep "\[NOT GENERATED\]" a lot today, tracking down missing stuff. This merge requests ignores every deprecated object before 3.14.

sdroege commented 4 years ago

Shouldn't we simply ignore them in gir directly if their deprecated version is before the minimum version and it is configured to remove deprecated things?

GuillaumeGomez commented 4 years ago

I agree with @sdroege's suggestion.

bilelmoussaoui commented 4 years ago

Shouldn't we simply ignore them in gir directly if their deprecated version is before the minimum version and it is configured to remove deprecated things?

Well, sometimes the object (for example Gtk.VScrollbar) is only mentioned as deprecated on the object doc

sdroege commented 4 years ago

Well, sometimes the object (for example Gtk.VScrollbar) is only mentioned as deprecated on the object doc

Then we should probably add a configuration for allowing to mark it as deprecated manually (and to add the version). That would also allow us to generate more accurate bindings in general for these things.

bilelmoussaoui commented 4 years ago

Makes sense, I will keep this open until there's such an option on gir and update this one accordingly