search

gtk-rs / gtk

DEPRECATED, use https://github.com/gtk-rs/gtk3-rs repository instead!
https://gtk-rs.org/
MIT License
1.25k stars 82 forks source link

Generate GtkGestureStylus #1024

Closed bilelmoussaoui closed 4 years ago

bilelmoussaoui commented 4 years ago

In the continuation of my previous merge requests.

I was wondering about two enums which are deprecated in 3.20, should be generated?

sdroege commented 4 years ago

I was wondering about two enums which are deprecated in 3.20, should be generated?

* `Gtk.ArrowPlacement`

* `Gtk.ToolbarSpaceStyle`

I think they're only used in GObject properties. Would we get those if we generate them, or were those properties deprecated before 3.14? I'd add them for now if that causes new API to be generated.

bilelmoussaoui commented 4 years ago

I should have waited till morning before submitting this, removed the unused enums.

I have only kept Gtk.GestureStylus & Gtk.DebugFlag

bilelmoussaoui commented 4 years ago

I was wondering about two enums which are deprecated in 3.20, should be generated?

* `Gtk.ArrowPlacement`

* `Gtk.ToolbarSpaceStyle`

I think they're only used in GObject properties. Would we get those if we generate them, or were those properties deprecated before 3.14? I'd add them for now if that causes new API to be generated.

they don't generate any new API

sdroege commented 4 years ago

I have only kept [...] Gtk.DebugFlag

That one also doesn't seem to be used anywhere.

bilelmoussaoui commented 4 years ago

Updated with get_axes manual binding as well

bilelmoussaoui commented 4 years ago

Somehow the CI failed to report it's state, but everything is green :)