gtk-rs / gtk

DEPRECATED, use https://github.com/gtk-rs/gtk3-rs repository instead!
https://gtk-rs.org/
MIT License
1.25k stars 82 forks source link

Use GtkScrollType in trampoline #1041

Closed EPashkin closed 4 years ago

EPashkin commented 4 years ago

@sdroege, @GuillaumeGomez We used not FFI-safe type in trampoline

EPashkin commented 4 years ago

Nightly compiler nags about it

EPashkin commented 4 years ago

@GuillaumeGomez we get new error in rustdoc: instead of ignoring it seems add sniped for "WidgetExtManual::fn hide_on_delete" from vendor.md two times

diff --git b/src/widget.rs a/src/widget.rs

index 01ccdca..6bb2cd1 100644

--- b/src/widget.rs
+++ a/src/widget.rs
@@ -64,28 +64,6 @@ pub trait WidgetExtManual: 'static {
     // rustdoc-stripper-ignore-next
     /// Calls `gtk_widget_destroy()` on this widget.
     ///
-    /// Utility function; intended to be connected to the `Widget::delete-event`
-    /// signal on a `Window`. The function calls `WidgetExt::hide` on its
-    /// argument, then returns `true`. If connected to ::delete-event, the
-    /// result is that clicking the close button for a window (on the
-    /// window frame, top right corner usually) will hide but not destroy
-    /// the window. By default, GTK+ destroys windows when ::delete-event
-    /// is received.
-    ///
-    /// # Returns
-    ///
-    /// `true`
-    /// Utility function; intended to be connected to the `Widget::delete-event`
-    /// signal on a `Window`. The function calls `WidgetExt::hide` on its
-    /// argument, then returns `true`. If connected to ::delete-event, the
-    /// result is that clicking the close button for a window (on the
-    /// window frame, top right corner usually) will hide but not destroy
-    /// the window. By default, GTK+ destroys windows when ::delete-event
-    /// is received.
-    ///
-    /// # Returns
-    ///
-    /// `true`
     /// # Safety
     ///
     /// This will not necessarily entirely remove the widget from existence but
sdroege commented 4 years ago

How did this ever work? That would've crashed at runtime and caused stack corruption :)

sdroege commented 4 years ago

@GuillaumeGomez We should do a bugfix release with this

GuillaumeGomez commented 4 years ago

CI issue should be fixed by https://github.com/GuillaumeGomez/rustdoc-stripper/pull/66

GuillaumeGomez commented 4 years ago

Mac failed because it took too much time. What a surprise. Well, let's merge then! :)