gtk-rs / gtk

DEPRECATED, use https://github.com/gtk-rs/gtk3-rs repository instead!
https://gtk-rs.org/
MIT License
1.25k stars 82 forks source link

gtk::Arrow not implemented? #933

Closed artonio closed 4 years ago

artonio commented 4 years ago

example from python:

button = Gtk.Button()
button.add(Gtk.Arrow(Gtk.ArrowType.LEFT, Gtk.ShadowType.NONE))

I can see gtk::ArrowType in the docs, but not the Arrow object

EPashkin commented 4 years ago

It was deprecated: https://developer.gnome.org/gtk3/stable/GtkArrow.html#gtk-arrow-new

gtk_arrow_new has been deprecated since version 3.14 and should not be used in newly-written code.
Use a GtkImage with a suitable icon.
sdroege commented 4 years ago

Yeah we should also hide gtk::ArrowType though. Who wants to make a PR? :)

gdesmott commented 4 years ago

@sdroege : is this just a matter of removing Gtk.ArrowType from Gir.toml?

sdroege commented 4 years ago

Yes

gdesmott commented 4 years ago

What about src/auto/menu_button.rs using it to bind the direction APIs?

sdroege commented 4 years ago

Hrm then this is actually fine. Only GtkArrow is deprecated and GtkArrowType is used in random other API and not deprecated yet.

@GuillaumeGomez This can be closed