search

gtk-rs / gtk

DEPRECATED, use https://github.com/gtk-rs/gtk3-rs repository instead!
https://gtk-rs.org/
MIT License
1.25k stars 82 forks source link

Issue #862 - Add size_allocate vfunc to gtk::Widget #961

Closed hfiguiere closed 4 years ago

hfiguiere commented 4 years ago

Replaces PR #959 (on master this time)

sdroege commented 4 years ago

So as part of this WidgetExt::size_allocate() should also be changed to not take a mutable reference.

EPashkin commented 4 years ago

@ebassi Thanks for the clarification. @hfiguiere Thanks for PR I restarted failed job in CI 👍

hfiguiere commented 4 years ago

So as part of this WidgetExt::size_allocate() should also be changed to not take a mutable reference.

This is auto generated.

sdroege commented 4 years ago

That's true, but it can be fixed like here https://github.com/gtk-rs/gtk/blob/2fcc48623a37a1f6899d56a1ce46d18d39e43e8e/Gir.toml#L680-L684 :)

hfiguiere commented 4 years ago

OK. Added it as a separate commit as this one we might want to skip cherry-picking to to 0.8

sdroege commented 4 years ago

OK. Added it as a separate commit as this one we might want to skip cherry-picking to to 0.8

Both can be backported :) Changing from &mut to & is not a breaking change.

sdroege commented 4 years ago

Otherwise looks good to me, thanks!

sdroege commented 4 years ago

@GuillaumeGomez please merge :)

GuillaumeGomez commented 4 years ago

Thanks!