search

gtk-rs / gtk

DEPRECATED, use https://github.com/gtk-rs/gtk3-rs repository instead!
https://gtk-rs.org/
MIT License
1.24k stars 82 forks source link

Add vfuncs to WidgetImpl #972

Closed tsahyt closed 4 years ago

tsahyt commented 4 years ago

These are some vfuncs that I previously added manually into my subclasses and are still missing.

I've verified that realize and unrealize work as intended. Map and unmap are mostly the same, and should work. I'm not entirely sure about motion_notify_event however, in particular about passing the second argument and whether it should really be mutable.

tsahyt commented 4 years ago

I've applied the suggested changes and renamed a variable for clarity. The CI came up red before because of what looked like a network error to me. I just wanted to mention that too.

sdroege commented 4 years ago

The CI came up red before because of what looked like a network error to me

Happens :)

sdroege commented 4 years ago

@GuillaumeGomez good to go once the CI is happy :) Thanks @tsahyt !

sdroege commented 4 years ago

@GuillaumeGomez time to merge :)